Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #867

wants to merge 1 commit into from

Conversation

YaroslavBordovoy
Copy link

@YaroslavBordovoy YaroslavBordovoy commented Nov 19, 2024 •
edited
Loading

image
image
image
image

MatvijSafonov
MatvijSafonov approved these changes Nov 20, 2024
View reviewed changes
Copy link

@MatvijSafonov MatvijSafonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 20, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 Your code is well-structured and meets most of the core requirements. While there are some minor improvements suggested, such as ensuring that user.id is correctly used in the driver-detail view, these do not significantly impact the functionality. Keep up the good work, and consider the feedback for future enhancements. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

templates/includes/sidebar.html
{% if user.is_authenticated %}
<li>
User:
<a href="{% url "taxi:driver-detail" pk=user.id %}">{{ user.username }}</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the user.id is the correct identifier for the driver-detail view. If user is not directly related to the Driver model, this might cause an issue.

AnyoneClown
AnyoneClown approved these changes Nov 25, 2024
View reviewed changes
Copy link

@AnyoneClown AnyoneClown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, but don't forget to add blank lines at the end of the files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatvijSafonov MatvijSafonov MatvijSafonov approved these changes

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@AnyoneClown AnyoneClown AnyoneClown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YaroslavBordovoy @AnyoneClown @mateacademy-ai-mentor @MatvijSafonov